Skip to content

🧹 fix code duplication in extractor scripts - #84

Open
savvides wants to merge 1 commit into
mainfrom
fix-extractor-duplication-8219125013309872649
Open

🧹 fix code duplication in extractor scripts#84
savvides wants to merge 1 commit into
mainfrom
fix-extractor-duplication-8219125013309872649

Conversation

@savvides

Copy link
Copy Markdown
Owner

🎯 What: Removed duplicate extraction functions (detectPageType, extractContentFromDOM, extractPageContent, detectCourseContext) by moving them to extension/shared/extractor-core.js.
💡 Why: It improves maintainability by removing code duplication and ensuring both the side panel and the content script operate off the same single source of truth without relying on duplicate .js or .cjs files.
Verification: Verified by ensuring the shared script is correctly configured in manifest.json and index.html. Mocked the globals in tests and confirmed the extension unit tests (./test/test-extension.sh) and full test suite (./test/smoke-test.sh) pass with full coverage of the extractor script behaviors. Also accounted for a tricky shim PATH limitation in testing by ensuring cut is safely mocked for pyenv.
Result: A more maintainable architecture that adheres to Chrome Extension constraints without introducing a bundler.


PR created automatically by Jules for task 8219125013309872649 started by @savvides

Moved identical functions from `extension/content/extractor.js` and `extension/content/extractor-core.js` into `extension/shared/extractor-core.js`. The content script now delegates to the shared code, and the side panel consumes the global variables directly. Evaluated and deleted the duplicate `.cjs` file while retaining Node.js export logic in the shared script to ensure the test suite continues running successfully. Fixed test paths to reference the new shared location.

Co-authored-by: savvides <1580637+savvides@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant