Skip to content

馃敀 Fix reverse tabnabbing vulnerability in sidepanel link - #83

Open
savvides wants to merge 1 commit into
mainfrom
fix-tabnabbing-vulnerability-8026939734531602552
Open

馃敀 Fix reverse tabnabbing vulnerability in sidepanel link#83
savvides wants to merge 1 commit into
mainfrom
fix-tabnabbing-vulnerability-8026939734531602552

Conversation

@savvides

Copy link
Copy Markdown
Owner
  • Added rel="noopener noreferrer" to the a tag in extension/sidepanel/index.html.
  • This ensures that external links opened in new tabs cannot manipulate the origin page context, effectively eliminating a reverse tabnabbing vulnerability.
  • Verified by checking frontend visually and running full test suites locally.

PR created automatically by Jules for task 8026939734531602552 started by @savvides

Adds the missing `rel="noopener noreferrer"` attribute to the external link
with `target="_blank"` on the AI Studio API key field in `extension/sidepanel/index.html`.
This mitigates a potential reverse tabnabbing attack where the newly opened window
could gain access to the originating window's context.

Co-authored-by: savvides <1580637+savvides@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant