🧪 test: Add missing error path coverage for crawlCanvasCourse - #80
🧪 test: Add missing error path coverage for crawlCanvasCourse#80savvides wants to merge 1 commit into
Conversation
Added tests to `test/test-crawler.js` that check if `crawlCanvasCourse` throws the expected error when invoked with a missing `origin` or missing `courseId`. This increases test coverage and ensures the validation logic is properly verified and maintains behavior correctly. Co-authored-by: savvides <1580637+savvides@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The testing gap addressed
The
crawlCanvasCoursevalidation logic for missingoriginandcourseIdinsideextension/background/canvas-crawler.cjswas missing an explicit unit test, reducing our confidence if validation was accidentally modified or removed.📊 Coverage: What scenarios are now tested
This commit adds checks ensuring
crawlCanvasCoursecatchesnull/undefinedappropriately:crawlCanvasCourse(null, '12345')throws "Canvas origin and courseId are required for course crawling."crawlCanvasCourse('https://canvas.instructure.com', null)throws "Canvas origin and courseId are required for course crawling."✨ Result: The improvement in test coverage
The error paths for parameter validation are fully covered, helping guarantee no regressions and ensuring parameter constraints are strictly upheld moving forward.
PR created automatically by Jules for task 3365728774031862764 started by @savvides