fix(admin): Feature Flags Enable/Disable buttons (Unknown action import) - #2083
Merged
Conversation
…-action FQN The #2060 editable Feature Flags UI wired the enable/disable buttons as Action: 'AdminService.FeatureFlags/enable' — the <qualifier>/<name> slash form is OData v4 UNBOUND ActionImport syntax, but enable/disable are BOUND actions on the FeatureFlags entity. Fiori Elements throws 'Unknown action import' client-side and never sends the POST, so the buttons do nothing (shipped in 1.20.1). Use the bound-action FQN AdminService.enable / AdminService.disable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On
/admin-ui/#featureFlags, the Enable/Disable buttons do nothing — the browser console throwsError: Unknown action import. Shipped in 1.20.1 (#2060, commit c203773).Cause
The
UI.DataFieldForActionannotations usedAction: 'AdminService.FeatureFlags/enable'. The<qualifier>/<name>slash form is OData v4 unbound ActionImport syntax, butenable/disableare bound actions on theFeatureFlagsentity (srv/admin-service.cds). Fiori Elements resolves it as a non-existent action import and errors client-side before any POST — so nothing toggles and a reload doesn't help.Fix
Use the bound-action FQN
AdminService.enable/AdminService.disable(4 occurrences: List Report + Object Page). Server side was always correct (unit testtest/unit/admin-feature-flags-toggle.test.jsposts the bound URL and asserts the flip).Deploy note
Admin-UI change → the admin bundle is raw-copied into the approuter by
mbt build, so this needs a FULL deploy (no--skip-build/-m) to take effect; verify the button post-deploy. Until then, flags are settable viaPOST /admin/setFeatureFlag.