Skip to content

fix: include path in canonicalization errors - #548

Merged
aawsome merged 1 commit into
rustic-rs:mainfrom
magrathean-uk:fix/issue-429-canonicalize-context
Aug 26, 2026
Merged

fix: include path in canonicalization errors#548
aawsome merged 1 commit into
rustic-rs:mainfrom
magrathean-uk:fix/issue-429-canonicalize-context

Conversation

@magrathean-uk

@magrathean-uk magrathean-uk commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • retain the failing path when canonicalization fails
  • include it in the user-facing error and regression test

Fixes #429

Validation

  • cargo test -p rustic_core path_list_sanitize_error_includes_path --locked
  • cargo check -p rustic_core --locked
  • cargo fmt --check

@magrathean-uk
magrathean-uk marked this pull request as ready for review August 25, 2026 09:34
aawsome
aawsome approved these changes Aug 26, 2026
View reviewed changes

@aawsome aawsome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @magrathean-uk

@aawsome
aawsome enabled auto-merge August 26, 2026 07:33
@aawsome
aawsome added this pull request to the merge queue Aug 26, 2026
Merged via the queue into rustic-rs:main with commit c4059e3 Aug 26, 2026
21 of 22 checks passed
@rustic-release-plz rustic-release-plz Bot mentioned this pull request Aug 26, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aawsome aawsome aawsome approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

canonicalizing path failed does not show which path failed

2 participants

@magrathean-uk @aawsome