[3.0.0 prep] New pcap_* bindings - #403
Conversation
506212a to
acd0254
Compare
|
Ready: Reason of additions:
I'm open to drop |
Wojtek242
left a comment
There was a problem hiding this comment.
Looks good. One minor comment to update a comment.
| }; | ||
| // libpcap has no entry points taking wide strings. It reads the path in the local code page, | ||
| // or in UTF-8 once pcap_init has been asked for that, so give it the UTF-8 form. A path that | ||
| // is not valid UTF-8 holds an unpaired surrogate, which has no form libpcap would accept. |
There was a problem hiding this comment.
I am not familiar with the term "unpaired surrogate". Is this a standard term in Windows or your term? If it's standard in Windows it can stay. If not, can you rephrase to rephrase this to make it a bit clearer?
There was a problem hiding this comment.
This is Unicode stuff. From U+D800 to U+DFFF are called (1x low + 1x high) surrogates and used for UTF-16. High and low surrogates must be in a pair to present anything higher than 2^16.
https://learn.microsoft.com/en-us/windows/win32/intl/surrogates-and-supplementary-characters
e4ab0cc to
4ab8409
Compare
pcap_initfixes #383 and supersedes #384.Must be merged after #400, and a rebase will be done then.