Skip to content

Initial implementation of #![feature(move_ref_pattern)] - #68376

Merged
bors merged 6 commits into
rust-lang:masterfrom
Centril:move-ref-patterns
Feb 9, 2020
Merged

Initial implementation of #![feature(move_ref_pattern)]#68376
bors merged 6 commits into
rust-lang:masterfrom
Centril:move-ref-patterns

Conversation

@Centril

@Centril Centril commented Jan 19, 2020

Copy link
Copy Markdown
Contributor

Following up on #45600, under the gate #![feature(move_ref_pattern)], (ref x, mut y) is allowed subject to restrictions necessary for soundness. The match checking implementation and tests for #![feature(bindings_after_at)] is also adjusted as necessary.

Closes #45600.
Tracking issue: #68354.

r? @matthewjasper

@Centril Centril added F-bindings_after_at `#![feature(bindings_after_at)]` F-move_ref_pattern `#![feature(move_ref_pattern)]` labels Jan 19, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
estebank
estebank reviewed Jan 25, 2020
View reviewed changes
Comment thread src/librustc_error_codes/error_codes/E0009.md Outdated
Comment thread src/librustc_mir_build/hair/pattern/check_match.rs Outdated
@estebank

estebank commented Jan 25, 2020

Copy link
Copy Markdown
Contributor

CC #30418

@Centril

Centril commented Jan 26, 2020

Copy link
Copy Markdown
Contributor Author

CC #30418

This unrelated error is comes from rustc_resolve and is specific to or-patterns:

matthewjasper
matthewjasper reviewed Jan 30, 2020
View reviewed changes
Comment thread src/test/ui/pattern/move-ref-patterns/move-ref-patterns-closure-captures-pass.rs Outdated
Comment thread src/librustc_mir_build/hair/pattern/check_match.rs Outdated
Comment thread src/librustc_mir_build/hair/pattern/check_match.rs Outdated
Centril
Centril commented Jan 30, 2020
View reviewed changes
Comment thread src/librustc_mir_build/hair/pattern/check_match.rs Outdated
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2020
@Centril Centril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 2, 2020
@Centril

Centril commented Feb 2, 2020

Copy link
Copy Markdown
Contributor Author

Addressed the comments. :)

@Centril

Centril commented Feb 2, 2020

Copy link
Copy Markdown
Contributor Author

Also, do you think the test suite is sufficient for eventual stabilization purposes or do you think more would be necessary?

@matthewjasper

matthewjasper commented Feb 8, 2020

Copy link
Copy Markdown
Contributor

I can't think of any other tests that I would want.
@bors r+

@bors

bors commented Feb 8, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit d2b88b7 has been approved by matthewjasper

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 8, 2020
@bors

bors commented Feb 9, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d2b88b7 with merge f8d830b...

@bors

ghost commented Feb 9, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: matthewjasper
Pushing f8d830b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 9, 2020
@bors
bors merged commit d2b88b7 into rust-lang:master Feb 9, 2020
@Centril
Centril deleted the move-ref-patterns branch February 9, 2020 07:31
@Centril Centril mentioned this pull request Feb 10, 2020
Closed
@Centril Centril mentioned this pull request Mar 8, 2020
Merged
@Centril Centril added A-exhaustiveness-checking Relating to exhaustiveness / usefulness checking of patterns A-patterns Relating to patterns and pattern matching labels Apr 10, 2020
@Amjad50 Amjad50 mentioned this pull request Aug 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebank estebank estebank left review comments
@matthewjasper matthewjasper matthewjasper left review comments

Assignees

@matthewjasper matthewjasper

Labels

A-exhaustiveness-checking Relating to exhaustiveness / usefulness checking of patterns A-patterns Relating to patterns and pattern matching F-bindings_after_at `#![feature(bindings_after_at)]` F-move_ref_pattern `#![feature(move_ref_pattern)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pattern errors are too imprecise and should be removed in favor of MIR borrowck

5 participants

@Centril @rust-highfive @bors @estebank @matthewjasper