Make CovariantUnsafeCell actually covariant - #163051
Open
asquared31415 wants to merge 1 commit into
Open
asquared31415 wants to merge 1 commit into
asquared31415 wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
Member
|
Maybe it's easier (and faster) to throw out the overridden constraints once, instead of checking whether to skip them on every iteration? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "test" in
corewas not actually being run, due to core being weird. (filed #163045 to track that)The existing mechanism for inserting variance manually was only priming the solver, which happened to work for the other two types using this mechanism, but does not work for weakening variance explicitly. I changed this mechanism to additionally prevent the variance from being updated when solving.
This blocks #159838
r? @WaffleLapkin as the implementor of
CovariantUnsafeCell