Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
3 tasks
mu001999
reviewed
Sep 20, 2026
| | ^^^^^ help: rename the identifier | ||
| | | ||
| = note: `super` cannot be used as a raw identifier | ||
| | ^^^^^ `super` cannot be used as a raw identifier |
Member
There was a problem hiding this comment.
IMO, there was nothing wrong with the previous diagnostics. We suggest renaming the identifier and note that super cannot be used as an identifier.
And we're not actually suggesting let Super to let super, right? :)
Contributor
Author
There was a problem hiding this comment.
The previous suggestion was to rename to no binding, ending up with invalid code. But yeah, looking at this with fresh eyes I should change it to have a suggestion for a different binding name. I'll rework this change.
mu001999
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.