Skip to content

Be more explicit on suggestion type without changing how they are rendered - #163041

Open
estebank wants to merge 1 commit into
rust-lang:mainfrom
estebank:explicit-suggestions
Open

estebank wants to merge 1 commit into
rust-lang:mainfrom
estebank:explicit-suggestions

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Replace span_suggestion calls with more specific ones, without affecting the output.

@rustbot

rustbot commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 19, 2026
@rustbot

rustbot commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 19 candidates

…dered

Replace `span_suggestion` calls with more specific ones, without affecting the output.
@estebank
estebank force-pushed the explicit-suggestions branch from a9283f7 to 54f9e87 Compare September 20, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants