Rollup of 6 pull requests - #162589
Closed
JonathanBrouwer wants to merge 19 commits into
Closed
Conversation
…dering object bounds
This makes their test environment consistent between runs inside the cg_clif and rust repos.
A fatal error that doesn't actually abort is indistinguishable from a regular error. And the only places where emit_almost_fatal is called, the produced FatalError is ignored.
The explanation provided was wrong. Libc doesn't exist on Windows, so naturally this failed on missing lib. I have no idea what shenanigans link.exe does to make this pass, but surely it doesn't actually link libc.
This avoids a delayed bug if compilation is aborted between checking function ABIs and codegening all functions.
And remove the encoded metadata if there are any errors or delayed bugs after encoding.
* fix(traits): Remove expression references from index suggestions * Use expression spans for index reference removal suggestions * refactor(trait-selection): Simplify dereference suggestion guard
re-equate the object bound's trait ref with the goal's when considering object bounds rust-lang/trait-system-refactor-initiative#295 bisects to rust-lang#152859, which changed `probe_and_consider_object_bound_candidate` to pass the trait object's trait ref in a binder to `predicates_for_object_candidate`, which calls `instantiate_binder_with_infer` on the binder. Re-instantiating the binder like this, however, loses the constraint that `'x: 'static`, even though earlier in `match_assumption` we actually did equate the object trait ref with the goal's trait ref, which gave us the `eq('x, 'static)` relationship we needed. However, the new inference var has no relationship with the equality we established; hence we lose `'x: 'static` and therefore `Self: 'static` and `'s: 'static`. We therefore inline `match_assumption` and directly equate the assumption's trait ref with the goal's before passing the assumption to `predicates_for_object_candidate` instead and remove the re-instantiation. fixes rust-lang/trait-system-refactor-initiative#295 cc @lcnr
Some cleanups around fatal errors and delayed bugs With the aim of making it easier to move some compiler passes to different locations. And in particular to allow moving them across `has_errors_or_delayed_bugs` calls. This is a prerequisite for a local change that improves the effectiveness of cargo build pipelining. Fixes rust-lang#152204
…ng_index, r=jieyouxu fix(traits): Remove expression references from index suggestions Fix issue: rust-lang#162419
… r=oli-obk Fix run-make/prune-link-args to work with MinGW The explanation provided was wrong. Libc doesn't exist on Windows, so naturally this failed on missing lib. I have no idea what shenanigans link.exe does to make this pass, but surely it doesn't actually link libc.
…=Darksonn doc: Fix external mention of signum() return value regarding NaNs `is_sign_positive()`/`is_sign_negative()` documentation refer to using `signum() ` but misrepresent the return value of the latter; `signum()` returns a float so it cannot be `false`; `signum()` documentation documents it as returning a NaN in this case, so propagated that to these references.
rustbot
added
A-LLVM
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162581 (Subtree sync for rustc_codegen_cranelift) - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds) - #162057 (Some cleanups around fatal errors and delayed bugs) - #162437 (fix(traits): Remove expression references from index suggestions) - #162534 (Fix run-make/prune-link-args to work with MinGW) - #162576 (doc: Fix external mention of signum() return value regarding NaNs)
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 9073adf failed: CI. Failed job:
|
Member
Author
|
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit cad7a6e with merge 2dd95b5... Workflow: https://github.com/rust-lang/rust/actions/runs/34475781969 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162581 (Subtree sync for rustc_codegen_cranelift) - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds) - #162057 (Some cleanups around fatal errors and delayed bugs) - #162437 (fix(traits): Remove expression references from index suggestions) - #162534 (Fix run-make/prune-link-args to work with MinGW) - #162576 (doc: Fix external mention of signum() return value regarding NaNs)
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. Auto build was cancelled due to the PR being closed. Cancelled workflows: |
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
r? @ghost
Create a similar rollup