Always escape grapheme extenders in str::escape_debug - #158303
Conversation
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-Unicode
Jules-Bertholet
changed the title
str::escape_debugstr::escape_debug
|
I'll go ahead and kick off an FCP here, and cc @Manishearth (but I imagine your opinion here will match that given on the other PRs). @rfcbot fcp merge libs-api |
|
@Mark-Simulacrum has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rust-rfcbot
added
proposed-final-comment-period
|
Yes this is fine. But I don't want to keep reviewing minor changes like this: if @Jules-Bertholet wants to keep making changes like this I would prefer seeing a proposal with a holistic strategy. |
Mark-Simulacrum
added
S-waiting-on-fcp
This comment has been minimized.
This comment has been minimized.
rust-rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
This matches the behavior of `impl Debug for str`.
fd70c0f to
66594ec
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rust-rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. |
|
@bors r+ rollup |
rust-bors
Bot
added
S-waiting-on-bors
…tender, r=Mark-Simulacrum Always escape grapheme extenders in `str::escape_debug` This matches the behavior of `impl Debug for str`. @rustbot label A-Unicode T-libs-api needs-fcp
…tender, r=Mark-Simulacrum Always escape grapheme extenders in `str::escape_debug` This matches the behavior of `impl Debug for str`. @rustbot label A-Unicode T-libs-api needs-fcp
…uwer Rollup of 11 pull requests Successful merges: - #160923 (Handle multiple action records in EH personality function) - #161788 (Check to ensure we're running against the correct LLVM version) - #158303 (Always escape grapheme extenders in `str::escape_debug`) - #161644 (bootstrap: Flatten and rename `compute_src_directory_via_git`) - #161702 (Use `drop_guard` in some places in {core,alloc,std}) - #161713 (Add config for gram editor to .gitignore) - #161792 (Fix and improve diagnostics for lint `rust_2021_prefixes_incompatible_syntax`) - #161931 (Revert "Add rustc_test_entrypoint_marker") - #162015 (touch up "get attribute" docs.) - #162019 (remove a couple of redundant clones, thanks clippy) - #162023 (Remove redundant braces from `NonZero` doctests)
…uwer Rollup of 11 pull requests Successful merges: - #160923 (Handle multiple action records in EH personality function) - #161788 (Check to ensure we're running against the correct LLVM version) - #158303 (Always escape grapheme extenders in `str::escape_debug`) - #161644 (bootstrap: Flatten and rename `compute_src_directory_via_git`) - #161702 (Use `drop_guard` in some places in {core,alloc,std}) - #161713 (Add config for gram editor to .gitignore) - #161792 (Fix and improve diagnostics for lint `rust_2021_prefixes_incompatible_syntax`) - #161931 (Revert "Add rustc_test_entrypoint_marker") - #162015 (touch up "get attribute" docs.) - #162019 (remove a couple of redundant clones, thanks clippy) - #162023 (Remove redundant braces from `NonZero` doctests)
6 participants
This matches the behavior of
impl Debug for str.@rustbot label A-Unicode T-libs-api needs-fcp