Skip to content

Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents - #135491

Merged
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:remove-dead-rustc_allowed_through_unstable_modules
Jan 20, 2025
Merged

Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents#135491
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:remove-dead-rustc_allowed_through_unstable_modules

Conversation

@RalfJung

@RalfJung RalfJung commented Jan 14, 2025

Copy link
Copy Markdown
Member

As far as I was able to reconstruct, the history here is roughly as follows:

I did a grep for pub use crate::os::fd and all the re-exports I could find are in stable modules. So given all that, we can remove the rustc_allowed_through_unstable_modules (hoping they are not also re-exported somewhere else, it's really hard to be sure about this).

I have checked that std still builds after this PR on the wasm32-wasip2 target.

@rustbot

ghost commented Jan 14, 2025

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-wasi Operating system: Wasi, Webassembly System Interface S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 14, 2025
@RalfJung RalfJung changed the title Remove dead rustc allowed through unstable modules Remove dead rustc_allowed_through_unstable_modules Jan 14, 2025
@RalfJung
RalfJung force-pushed the remove-dead-rustc_allowed_through_unstable_modules branch from 07ef681 to fdbca1a Compare January 14, 2025 16:28
@RalfJung
RalfJung force-pushed the remove-dead-rustc_allowed_through_unstable_modules branch from fdbca1a to f3cf39f Compare January 14, 2025 16:28

ghost Jan 14, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to io/tests to match library/std/src/os/unix/io/tests.rs.

@RalfJung RalfJung changed the title Remove dead rustc_allowed_through_unstable_modules Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents Jan 14, 2025
@Mark-Simulacrum

ghost commented Jan 19, 2025

Copy link
Copy Markdown
Member

@bors r+

@bors

ghost commented Jan 19, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit f3cf39f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2025
@bors
bors merged commit e1e26f3 into rust-lang:master Jan 20, 2025
@rustbot rustbot added this to the 1.86.0 milestone Jan 20, 2025
@RalfJung
RalfJung deleted the remove-dead-rustc_allowed_through_unstable_modules branch January 20, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-wasi Operating system: Wasi, Webassembly System Interface S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression on nightly when compiling mio for wasm32-wasi

4 participants