refactor(git-hooks): consolidate hook path and remove ci/ validators - #222
Closed
ruby-automation wants to merge 1 commit into
Closed
refactor(git-hooks): consolidate hook path and remove ci/ validators#222ruby-automation wants to merge 1 commit into
ruby-automation wants to merge 1 commit into
Conversation
Replace the two legacy ci/ validation scripts (conventional_commits.sh, validate_conventional_commit.sh) with direct calls to their counterparts under git-hooks/: git-hooks/validate-commit-range and git-hooks/validate-conventional-subject. - Delete ci/conventional_commits.sh and ci/validate_conventional_commit.sh - Update .github/workflows/ci.yaml to run ./git-hooks/validate-commit-range - Update app/usage-rules.md to reference git-hooks/validate-commit-range The hook installer (mix git_hooks), the hook wrappers (git-hooks/commit-msg and git-hooks/pre-push), the shared validators, and documentation were already updated by EXT-29 (db08f0e / 044459e). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
Rework completeThis addresses the blocking architecture correction raised in review. What changed:
Tests updated:
All 27 tests pass; formatting clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci/conventional_commits.shandci/validate_conventional_commit.sh— the validation logic now lives entirely ingit-hooks/validate-commit-rangeandgit-hooks/validate-conventional-subject(landed in EXT-29 / ci: harden Conventional Commit validators and Git test isolation #218).github/workflows/ci.yamlto run./git-hooks/validate-commit-rangeinstead of the deleted scriptapp/usage-rules.mdto reference the new script pathThe hook installer (
mix git_hooks), the hook wrappers (git-hooks/commit-msgandgit-hooks/pre-push), the shared validators, and all other documentation were already updated by EXT-29.Closes EXT-30.
Test plan
mix test(root, 35 tests) — all passmix ci(full app quality gate, 405 tests) — all passmix format --check-formatted(root) — cleanci/conventional_commits.sh,ci/validate_conventional_commit.sh, orgithooks/outside historical plan/changelog files🤖 Generated with Claude Code