Add ticket payment due date to events - #2173
Merged
Merged
Conversation
maebeale
force-pushed
the
maebeale/payment-due-reminders
branch
from
August 12, 2026 02:12
7252fde to
0a940ae
Compare
maebeale
marked this pull request as ready for review
August 12, 2026 02:17
A payment deadline for the event ticket, distinct from the CE payment deadline: migration, virtual date/time accessors, decorator display, permitted params, and an admin form field next to cost. Also marks the required start/end date inputs with SimpleForm's required marker, matching the admin-form convention. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The payment card's due badge now reads e.g. "$1,350 due by Apr 9", and the payment callout page shows the deadline under the amount-due pill and in the pay-by-check note (replacing hardcoded copy). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/payment-due-reminders
branch
from
August 12, 2026 02:38
b6fe072 to
d724b06
Compare
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 new event column surfaced on the payment callout; contained logic, no scheduled sends
What is the goal of this PR and why is this important?
How did you approach the change?
events.payment_due_deadlinedatetime, mirroring the CE deadline pattern: virtual date/time accessors, decorator display, permitted params, and an admin form field next to cost.BuiltinCalloutCards#payment_cardappends the deadline to the "due" badge;payment.html.erbrenders the real deadline instead of the hardcoded "April 9th".Anything else to add?