Skip to content

Fix Target.targetCreated handler for existing targets - #539

Merged
route merged 2 commits into
rubycdp:mainfrom
markiz:ma/fix-target-created-event
Aug 8, 2026
Merged

Fix Target.targetCreated handler for existing targets#539
route merged 2 commits into
rubycdp:mainfrom
markiz:ma/fix-target-created-event

Conversation

@markiz

@markiz markiz commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Came up in our large system spec suite, Client does not respond to session_id, so I'm assuming target#session_id should be right here. Haven't seen any errors related to that since.

@route

route commented Aug 8, 2026

Copy link
Copy Markdown
Member

I guess you are running specs with ferrum flatten: false, any chance to switch to true?

@route
route merged commit 26a7d17 into rubycdp:main Aug 8, 2026
7 checks passed
@markiz

markiz commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

@route

I guess you are running specs with ferrum flatten: false

yeah. I'm afraid I don't remember the exact reason why we had to switch to flatten: false, but it probably had to do with stability.

I guess you are running specs with ferrum flatten: false, any chance to switch to true?

Yeah, checking it out. I'm seeing some performance regressions with flatten (5-6 minutes runs vs 3-4 minutes; the normal deviation for this particular suite is ~1 minute though), and also some intermittent Browser is dead or given window is closed.

Is that going to be the new default or something in v1?

@route

route commented Aug 10, 2026

Copy link
Copy Markdown
Member

Interesting, by any chance any reproducible test out of your project, at least for the error, perfomance regressions would be hard to debug, but very interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants