pkey: avoid using {DH,DSA,RSA}#public_key in docs and tests - #1092
Merged
Conversation
As documented, the #public_key methods on OpenSSL::PKey::{DH,DSA,RSA}
are obsolete, as their behavior is inconsistent and better alternatives
are available. Remove unnecessary uses from RDoc comments for other
methods.
Also add dedicated tests for these methods to confirm the current
behavior.
4 tasks
Member
|
Thanks for the PR! |
junaruga
added a commit
to junaruga/ruby-drb
that referenced
this pull request
Aug 18, 2026
OpenSSL::PKey::RSA#public_key is obsolete according to ruby/openssl#1092.
junaruga
added a commit
to junaruga/ruby-drb
that referenced
this pull request
Aug 18, 2026
OpenSSL::PKey::RSA#public_key is obsolete according to ruby/openssl#1092.
Member
Author
|
Test failures are unrelated to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As documented, the #public_key methods on OpenSSL::PKey::{DH,DSA,RSA} are obsolete, as their behavior is inconsistent and better alternatives are available. Remove unnecessary uses from RDoc comments for other methods.
Also add dedicated tests for these methods to confirm the current behavior.
Reported by @junaruga at ruby/drb#53 (comment).