Skip to content

Map IO::TimeoutError to Net::OpenTimeout #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 2 commits into from
Sep 26, 2026
Merged

Map IO::TimeoutError to Net::OpenTimeout #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d3f182
Map `IO::TimeoutError` to `Net::TimeoutError`
jbourassa Sep 24, 2026
525656d
✅ Add test for Net::OpenTimeout error
nevans Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/imap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3702,7 +3702,7 @@ def tcp_socket(host, port)
s = Socket.tcp(host, port, :connect_timeout => open_timeout)
s.setsockopt(:SOL_SOCKET, :SO_KEEPALIVE, true)
s
rescue Errno::ETIMEDOUT
rescue Errno::ETIMEDOUT, IO::TimeoutError
raise Net::OpenTimeout, "Timeout to open TCP connection to " +
"#{host}:#{port} (exceeds #{open_timeout} seconds)"
end
Expand Down
8 changes: 8 additions & 0 deletions test/net/imap/test_imap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@ class IMAPTest < Net::IMAP::TestCase
end
end

def test_open_timeout
host = ENV.fetch("TEST_OPEN_TIMEOUT_HOST", "10.255.255.1")
pend host if host.start_with? "skip"
assert_raise(Net::OpenTimeout) do
Net::IMAP.new(host, open_timeout: 0)
end
end

def test_unexpected_eof
server = create_tcp_server
port = server.addr[1]
Expand Down
Loading