Skip to content

Refactor pushws command #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GabrielLidenor wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −3
Open

Refactor pushws command #1246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b75ac8c
refactor: magic number
GabrielLidenor Sep 5, 2026
ca9a732
fix: typo inspection_resuls
GabrielLidenor Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/irb/command/pushws.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,22 @@ module Command
class Workspaces < Base
category "Workspace"
description "Show workspaces."
MAX_WORKSPACE_INSPECT_LENGTH = 20

def execute(_arg)
inspection_resuls = irb_context.instance_variable_get(:@workspace_stack).map do |ws|
inspection_results = irb_context.instance_variable_get(:@workspace_stack).map do |ws|
truncated_inspect(ws.main)
end

puts "[" + inspection_resuls.join(", ") + "]"
puts "[" + inspection_results.join(", ") + "]"
end

private

def truncated_inspect(obj)
obj_inspection = obj.inspect

if obj_inspection.size > 20
if obj_inspection.size > MAX_WORKSPACE_INSPECT_LENGTH
obj_inspection = obj_inspection[0, 19] + "...>"
end

Expand Down