stream: improved support for large tag files - #921
Conversation
75ed149 to
42d8695
Compare
|
Suggested simpler option from AI: This achieves the same result with less surface area — two small wrapper functions (xftell/xfseek) instead of duplicating the platform split at each of the six call sites. A few other things it picks up along the way: WIN32 vs _WIN32: the new guards here use _WIN32, but the rest of stream.c (and its own header comment: * options : -DWIN32 use WIN32 API) consistently uses WIN32 without the underscore. _WIN32 is auto-defined by any Windows compiler so this will work in practice, but it's inconsistent with the file's established convention and introduces a second, parallel "is this Windows" check. Patch |
42d8695 to
ae6380c
Compare
|
Can abstract it that way, updated. |
|
Thanks for updating, AI still had a couple minor issues:
|
There was already 8 byte tag file support and this was expected to work for some builds, but windows in particilar is a special case.
ae6380c to
0122539
Compare
|
Fixed. |
There was already 8 byte tag file support and this was expected to work for some builds, but windows in particilar is a special case.