Skip to content

perf(fmt): use tiny-readdir context #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Aug 5, 2026
Merged

perf(fmt): use tiny-readdir context #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions packages/rstack/src/fmt/discoverPaths.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import path from 'node:path';
import ignore from 'ignore';
import isBinaryPath from 'is-binary-path';
import micromatch from 'micromatch';
import readdir, { type Dirent } from 'tiny-readdir';
import readdir, { type Dirent, type DirentLike } from 'tiny-readdir';

const defaultIgnoredDirNames = new Set(['.git', '.sl', '.svn', '.hg', '.jj', 'node_modules']);

Expand Down Expand Up @@ -45,10 +45,6 @@ const toPosixPath = (filePath: string): string =>
const getDirentParentPath = (dirent: Dirent): string =>
(dirent as Dirent & { parentPath?: string }).parentPath ?? dirent.path;

/** Mirrors the path passed to tiny-readdir's ignore callback. */
const getDirentPath = (dirent: Dirent, parentPath: string): string =>
`${parentPath}${parentPath === path.sep ? '' : path.sep}${dirent.name}`;

const hasBuiltInIgnoredSegment = (
cwd: string,
filePath: string,
Expand Down Expand Up @@ -218,18 +214,16 @@ const createTraversalOptions = (
isIncluded?: (filePath: string) => boolean,
isDirectoryIgnored?: (directoryPath: string) => boolean,
) => {
// tiny-readdir passes only a path to `ignore`, so retain the dirent type briefly.
const directories = new Set<string>();

return {
followSymlinks: false,
ignore: (targetPath: string) => {
const isDirectory = directories.delete(targetPath);
if (ignoredDirNames.has(path.basename(targetPath))) {
ignore: (targetPath: string, targetContext: DirentLike) => {
// With symlink following disabled, tiny-readdir always provides a Dirent here.
const dirent = targetContext as Dirent;
if (ignoredDirNames.has(dirent.name)) {
return true;
}

if (isDirectory) {
if (dirent.isDirectory()) {
return gitIgnore.isIgnored(targetPath, true) || isDirectoryIgnored?.(targetPath) === true;
}

Expand All @@ -244,9 +238,6 @@ const createTraversalOptions = (
let hasGitIgnore = false;

for (const dirent of dirents) {
if (dirent.isDirectory()) {
directories.add(getDirentPath(dirent, parentPath));
}
if (dirent.name === '.gitignore') {
hasGitIgnore = true;
}
Expand Down