Skip to content

Use multicall in GetMegapoolValidatorDetails - #1209

Open
thomaspanf wants to merge 2 commits into
masterfrom
megapool-details-multicall
Open

Use multicall in GetMegapoolValidatorDetails#1209
thomaspanf wants to merge 2 commits into
masterfrom
megapool-details-multicall

Conversation

@thomaspanf

Copy link
Copy Markdown
Member

Noticeable speedup especially for big megapools. Builds on top of a previous change (#1182) scoping the network state to the node when calling GetNodeMegapoolValidators

time rocketpool megapool status tested on hoodi:

Megapool validators Before After
2055 16.359s 1.330s
15 1.567s 0.532s
1 1.024s 0.491s

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Coverage Report

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool/node 0.51% (+0.00%) 👍
github.com/rocket-pool/smartnode/shared/services 0.25% (+0.00%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool/node/defend-challenge-exit.go 0.00% (ø) 2967 (-74) 0 2967 (-74)
github.com/rocket-pool/smartnode/rocketpool/node/stake-megapool-validator.go 0.00% (ø) 3365 (-74) 0 3365 (-74)
github.com/rocket-pool/smartnode/shared/services/megapools.go 0.59% (+0.00%) 20914 (-118) 124 20790 (-118) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant