Conversation
luhenry
changed the title
Drives upstream's maturin/pyo3 build (release.yml's linux job) through cibuildwheel, narrowed to riscv64. abi3-py310 is unconditional in Cargo.toml, so one cp310 build covers cp310-cp314; musllinux is dropped (no riscv64 musl rustup target). Includes a small patch to tests/functional/conftest.py so the functional suite reuses the wheel cibuildwheel already built instead of rebuilding deptry from scratch a second time via `uv build`.
poetry pulls keyring -> SecretStorage -> cryptography on Linux. Without PIP_ONLY_BINARY=cryptography, pip resolves whatever cryptography release is newest on PyPI, which is newer than what pypi.riseproject.dev has a riscv64 wheel for, and tries to build it from source -- failing on a missing OpenSSL dev install (openssl-sys can't find openssl.pc).
test_text_reporter_only/test_all_reporters run deptry against cwd's own pyproject.toml (mirrors upstream's `uv run deptry python` quality-job step); without it staged, the dependency getter builder finds nothing and raises DependencySpecificationNotFoundError instead of the expected SystemExit. Verified locally: 179 passed (was 177 passed, 2 failed).
ensurepip's bundled pip on the manylinux_riscv64 image doesn't recognize the riscv64 wheel tag, so the poetry/pdm/uv/pip fixture venvs functional tests create with venv.EnvBuilder fail to install our own riscv64 wheel with "... is not a supported wheel on this platform" even though the outer cibuildwheel test venv's own pip installs the identical wheel without complaint. Verified locally (doesn't reproduce off riscv64, but the extra `pip install --upgrade pip` step is a no-op there and the functional suite still passes: 38 passed, 1 skipped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deptry0.25.1Builds deptry's pyo3/maturin Rust extension, a CLI that scans a Python project for unused, missing and transitive dependencies. Upstream publishes no riscv64 wheel.
Mirrors upstream's
release.ymllinuxjob, driven through cibuildwheel instead ofPyO3/maturin-action.Differs from upstream
Matrix: cp310-abi3 (covers cp310-cp314) -
pyo3'sabi3-py310feature is unconditional inCargo.toml. Upstream ships no free-threaded wheel either.Testing
License: OK
Patches
0001-tests-allow-functional-tests-to-reuse-a-prebuilt-whe.patch- Inappropriate [CI-infra]. Avoids rebuilding deptry from scratch withuv builda second time. Reproduces off riscv64 too.0002-tests-upgrade-pip-in-each-throwaway-venv-before-inst.patch- Inappropriate [CI-infra]. ensurepip's bundled pip in the fixture venvs doesn't recognize the riscv64 wheel tag. Does not reproduce off riscv64.Built on cp310; 179 passed, 2 skipped (unit) and 38 passed, 1 skipped (functional), on every retested interpreter (cp310-cp314).