fix(ui): resolve TypeScript errors in CachedImage.tsx (closes #1199) - #1204
Open
rupesh-kumar-sah wants to merge 1 commit into
Open
rupesh-kumar-sah wants to merge 1 commit into
rupesh-kumar-sah wants to merge 1 commit into
Conversation
…de#1199) - Annotate aspectRatioStyle and detectedDimensions with DimensionValue to fix type narrowing - Use onLoad prop on ExpoImage instead of deprecated onLoadingComplete - Remove duplicate unused appLogger import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1199.
Addresses all TypeScript compilation errors reported by
tsc --noEmitinsrc/components/ui/CachedImage.tsx:undefined: undefinedtyping onaspectRatioStyleanddetectedDimensionswith proper React state types (DimensionValue) so TypeScript avoids dead-code narrowing toneverwhile preserving runtime falsiness.ExpoImageloading callback from deprecatedonLoadingCompletetoonLoad.appLoggerimport fromsrc/utils/logger.Verification
npx tsc --noEmitreports zero errors forsrc/components/ui/CachedImage.tsx.npx eslint src/components/ui/CachedImage.tsxpasses with zero errors and zero warnings.