Avoid iOS 16 URL parsing crash in stringWithUserAndPasswordStripped - #4
Merged
Merged
Conversation
URL.user()/password() (the percent-encoded accessors) share internal parsing code with URL.host(percentEncoded:) on iOS 16, and calling them there can crash inside host parsing even though host is never touched here. Gate the fast path on iOS 17 instead, so iOS 16 falls back to the legacy user/password properties, which don't hit the bug. See https://forums.swift.org/t/70452 for the same crash signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URL.user()/password()(the percent-encoded accessors) share internal parsing code withURL.host(percentEncoded:)on iOS 16, and calling them can crash inside host parsing even though host is never touched instringWithUserAndPasswordStripped.user/passwordproperties, which don't hit the bug.Test plan