Move std::unique_ptr APIs behind PLUME_CPP_STD_ENABLED - #109
Draft
IsaacMarovitz wants to merge 3 commits into
Draft
IsaacMarovitz wants to merge 3 commits into
IsaacMarovitz wants to merge 3 commits into
Conversation
IsaacMarovitz
force-pushed
the
unique_ptr
branch
4 times, most recently
from
September 17, 2026 02:30
ded52d0 to
73dc22b
Compare
IsaacMarovitz
force-pushed
the
unique_ptr
branch
from
September 17, 2026 02:44
73dc22b to
13a96f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of #107. This is a breaking change. C++ doesn't allow overloads with different return types, so the API that returns unique_ptrs has been moved to functions suffixed by
Unique.There may be better way to do this I've not figured out yet but this works for now.