fix(i18n): keep the German card label capitalised in the empty-column hint - #173
Open
grafst wants to merge 1 commit into
Open
fix(i18n): keep the German card label capitalised in the empty-column hint#173grafst wants to merge 1 commit into
grafst wants to merge 1 commit into
Conversation
… hint The empty-column view lowercases the plural card label before it is interpolated, which reads naturally in English but breaks German, where nouns are always capitalised: the board showed "Keine datensätze in dieser Spalte". Use Laravel's capitalising placeholder in the German line so the label comes back capitalised. No other locale is affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
empty-column.blade.phplowercases the plural card label before interpolating it:That reads naturally in English ("No records in this column"), but German capitalises every noun, so a German board shows:
Fix
Use Laravel's capitalising placeholder (
:CardLabel) in the German line, so the label is restored to Datensätze after the view lowercased it:One line, German only —
en,esandnlare untouched, and the view needs no change.Test
tests/Unit/TranslationTest.phprenders the component in German and asserts the capitalised hint. It fails on4.xwithout the lang change and passes with it;vendor/bin/pest tests/Unitstays green (43 passed).