fix(release): allow promotion to verify draft - #777
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68e1997cff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| permissions: | ||
| actions: read | ||
| contents: read | ||
| contents: write |
There was a problem hiding this comment.
The reviewed commit message has no Signed-off-by: trailer, so it violates the repository's requirement that every commit be created with git commit -s and will fail DCO enforcement. Recreate this commit with the required sign-off before merging.
AGENTS.md reference: AGENTS.md:L272-L275
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
contents: writefor the image-promotion jobRoot cause
Publication run 31768565679 failed before registry login because the image-promotion job could not read the unpublished bound draft with a read-only
GITHUB_TOKEN. GitHub returned403 Resource not accessible by integration. A recent permission minimization had reintroduced this previously fixed failure.The workflow-level default remains
contents: read; the write permission is limited to the protected-main job that already promotes final images. Checkout credentials remain disabled.Recovery
The existing immutable v0.22.0 tag and exact candidate remain valid. The failed run created an exact unpublished draft but wrote no final OCI, npm, PyPI, public release, or docs state. After this PR merges and protected-main CI passes, a new publication dispatch will reconcile that same tagged candidate and draft.
Validation
actionlintpassedgit diff --checkpassed