fix(release): enforce Node client glibc toolchain - #773
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f67f0d29cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # so route its host C and C++ compilers through napi-rs' locked | ||
| # glibc 2.17 toolchain too. Otherwise it inherits the Ubuntu 24.04 | ||
| # headers even though Rust links with the older toolchain. | ||
| export HOST_CC="${{ matrix.target }}-gcc" |
There was a problem hiding this comment.
Commit e9b789715c1fe3578ad74b3a04e963b0f4f362f1 has no Signed-off-by trailer, so the repository's DCO workflow will reject the contribution; recreate the commit with git commit -s or otherwise add a valid sign-off before submission.
AGENTS.md reference: AGENTS.md:L274-L274
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
Candidate run
31744651325failed both Linux client lanes on the supported Debian 11 baseline withundefined symbol: __isoc23_sscanf. napi-rs selected its glibc 2.17 linker throughTARGET_*, butaws-lc-systreats same-architecture builds as native and selected the Ubuntu 24.04 host compiler throughHOST_*. The mixed toolchains left an unversioned future-glibc import thatreadelf --version-infocould not see.Impact
The candidate now uses one glibc 2.17 toolchain for Rust linking and AWS-LC C/C++ compilation. The real baseline runtime smoke remains the authoritative compatibility proof. No release metadata or product code changes in this PR.
Verification
actionlintpassedgit diff --checkpassedCandidate evidence: https://github.com/registrystack/registry-stack/actions/runs/31744651325