-
Notifications
You must be signed in to change notification settings - Fork 0
fix(release): preserve tagged release records #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ artifacts: | |
|
|
||
| identifier_catalog: | ||
| path: products/identifiers/generated/catalog.v1.json | ||
| sha256: 7a8130406862922a1c52f81a43577446713ab10ffe76b49179946ad861af3ac9 | ||
| sha256: f5523ec180e3c3d18f7f18a1704d3932e84a66f03ead0e9124d3c6d366aa20f0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The reviewed commit has no AGENTS.md reference: AGENTS.md:L272-L275 Useful? React with 👍 / 👎. |
||
| entry_count: 47 | ||
|
|
||
| external: {} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -270,6 +270,20 @@ def sha256(path: Path) -> str: | |
| return hashlib.sha256(path.read_bytes()).hexdigest() | ||
|
|
||
|
|
||
| def local_tag_target(repo: Path, tag: str) -> str | None: | ||
| resolved = subprocess.run( | ||
| ["git", "rev-parse", "--verify", f"refs/tags/{tag}^{{}}"], | ||
| cwd=repo, | ||
| text=True, | ||
| capture_output=True, | ||
| check=False, | ||
| ) | ||
| target = resolved.stdout.strip() | ||
| if resolved.returncode == 0 and HEX40.fullmatch(target): | ||
| return target | ||
| return None | ||
|
|
||
|
|
||
| def validate(manifest_path: Path) -> int: | ||
| manifest = load_yaml(manifest_path) | ||
| errors: list[str] = [] | ||
|
|
@@ -318,12 +332,15 @@ def validate(manifest_path: Path) -> int: | |
| if repository.returncode == 0 and repository.stdout.strip() | ||
| else ROOT | ||
| ) | ||
| catalog_source_ref = source_ref if has_source_ref else None | ||
| if catalog_source_ref is None: | ||
| catalog_source_ref = local_tag_target(repo_root, source_tag) | ||
|
Comment on lines
+336
to
+337
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
In a shallow or tagless checkout, AGENTS.md reference: AGENTS.md:L261-L268 Useful? React with 👍 / 👎. |
||
| errors.extend( | ||
| identifier_catalog_errors( | ||
| version, | ||
| identifier_catalog, | ||
| repo_root, | ||
| source_ref if has_source_ref else None, | ||
| catalog_source_ref, | ||
| ) | ||
| ) | ||
| for name, artifact_version in sorted(artifacts.items()): | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit changes both
release/anddocs/site/, while the rootAGENTS.mdrequires each change to remain scoped to one owning area. Move the public changelog edit into a separate docs-site change from the release tooling, manifest, and release-note corrections.AGENTS.md reference: AGENTS.md:L280-L282
Useful? React with 👍 / 👎.