Skip to content

[DRAFT] Example v2 inventory - #58

Closed
spyrexd wants to merge 1 commit into
redhat-cop:v2from
spyrexd:MFG-484-inventory-updates
Closed

[DRAFT] Example v2 inventory#58
spyrexd wants to merge 1 commit into
redhat-cop:v2from
spyrexd:MFG-484-inventory-updates

Conversation

@spyrexd

@spyrexd spyrexd commented Aug 6, 2026

Copy link
Copy Markdown

Description

Type of Change

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation changes
  • style: Formatting, missing semi colons, etc; no code change
  • refactor: Refactoring production code
  • test: Adding missing tests, refactoring tests; no production code change
  • chore: Updating configs, etc; no production code change

Pull Request Title

Note: Please ensure your PR title follows Conventional Commits.
Example: feat: add role

  • I have formatted my PR title correctly.

@spyrexd
spyrexd requested a review from sabre1041 as a code owner August 6, 2026 15:17
Comment thread inventory2.yaml
# aap_hostname: aap.example.com
# aap_validate_certs: true

migration_clusters:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing hosts

Comment thread inventory2.yaml
# a permanent SA API key
# openshift_api_key: # This is a permanent Service Account API key. If you don't have a Service Account,
# one can be generated if you provide a tempoarary api key via openshift_temporary_api_key, or if you provide
# openshift_username + openshift_password to generate a temporary api key for you.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove openshift_username and openshift_password so that we only accept a token moving forward.

I still think we should keep the openshift_temporary_api_key for some "utility" reasons. But, should we remove the credential property and just keep it flat?

Comment thread inventory2.yaml
# aap_validate_certs: true

migration_clusters:
ocp_cluster1:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add another property openshift_ca_cert_path that represents the path of a file containing the CA certificate for OpenShift

@spyrexd

spyrexd commented Aug 19, 2026

Copy link
Copy Markdown
Author

@tech2734 @sabre1041 Are we good to close this PR now? The sample inventory should be good to go?

@sabre1041

Copy link
Copy Markdown
Contributor

@tech2734 @sabre1041 Are we good to close this PR now? The sample inventory should be good to go?

Agree that we should be good with the existing inventory file

@sabre1041 sabre1041 closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants