Add generic postcode/address lookup with pluggable drivers - #1
Merged
Conversation
Jade-GG
requested changes
Sep 7, 2026
Jade-GG
left a comment
Collaborator
There was a problem hiding this comment.
I notice that this only supports dutch postcodes right now, is that correct? If this is intended, the readme should probably reflect that.
| @@ -0,0 +1,31 @@ | |||
| <?php | |||
|
|
|||
| namespace Rapidez\Postcode\DataTransferObjects; | |||
Collaborator
There was a problem hiding this comment.
As far as I know, in other packages we put this under just ...\Data, but I'm not 100% confident on that so double check this before changing anything
Member
Author
There was a problem hiding this comment.
Double-checked this, couldn't find that convention anywhere (searched in our Rapidez packages' file trees plus a full code search). Keeping DataTransferObjects for now, happy to revisit if you know of one I missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rapidez/postcodeis a generic postcode/address lookup package with a pluggable driver architecture, instead of building yet another single-purpose packagepostcodeeu(Postcode.eu),pro6pp(Pro6pp),postcodeservice(Postcodeservice); each calling its API directly from Rapidez, no Magento dependency required for the lookuppostcode-changeVue event already wired into Rapidez's own address form, so it works out of the box with no Blade template changesrapidez/core^5.0 (relies on the event helper introduced in v5)Test plan
.env/config change, no code changes neededref: RAP-2028