Conversation
jtskxx
marked this pull request as draft
July 27, 2026 19:55
jtskxx
marked this pull request as ready for review
July 31, 2026 16:53
Contributor
|
please resolve the conflicts |
Contributor
Author
|
Do not merge please, review are welcome :) |
cyber-pc
reviewed
Sep 4, 2026
| } | ||
|
|
||
| locals.transferAmount = sint64(state.get().locker.get(locals.t)._lockedAmount + locals.rewardAmount); | ||
| qpi.transfer(state.get().locker.get(locals.t).ID, locals.transferAmount); |
Contributor
There was a problem hiding this comment.
I am not sure but I see in other places, the transfer failure cause the early return and don't process further, does if apply for this transfer too ?
| locals.log = {QEARN_CONTRACT_INDEX, SELF, qpi.invocator(), locals.transferAmount, QearnSuccessFullyUnlocking, 0}; | ||
| LOG_INFO(locals.log); | ||
| locals._rewardAmount = div(state.get().locker.get(locals._t)._lockedAmount * locals._rewardPercent, 10000000ULL); | ||
| qpi.transfer(state.get().locker.get(locals._t).ID, locals._rewardAmount + state.get().locker.get(locals._t)._lockedAmount); |
Contributor
There was a problem hiding this comment.
Please check, does it transfer need to be verified its success or we can process whatever its status?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces QEarn V2 starting at epoch 227, with three fixed lock periods:
These are maximum returns for the full term, not APY. Actual returns depend on the available bonus and
participation
For each lock epoch:
Early exits
Existing V1 positions keep their original rules
The V2 state is appended using PADDING at epoch 227, preserving the complete V1 state. Existing legacy interfaces
remain compatible and create 52-epoch positions after activation
Dedicated V2 procedures and queries are added for selecting and displaying the three terms
Coverage includes: