Conversation
overcat
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
September 20, 2026 01:19
|
All commit authors signed the Contributor License Agreement. |
cocolato
reviewed
Sep 20, 2026
cocolato
left a comment
cocolato
left a comment
Member
There was a problem hiding this comment.
we can add a mask macro like this:
#define _Py_METH_CALL_FLAGS \
(METH_VARARGS | METH_FASTCALL | METH_NOARGS | METH_O | METH_KEYWORDS | METH_METHOD)
Comment on lines
+4874
to
+4878
| int flags = PyCFunction_GET_FLAGS(callable_o); | ||
| // METH_CLASS, METH_STATIC and METH_COEXIST do not change the C | ||
| // calling convention, and the specializer ignores them. | ||
| flags &= ~(METH_CLASS | METH_STATIC | METH_COEXIST); | ||
| EXIT_IF(flags != METH_O); |
Member
There was a problem hiding this comment.
Suggested change
| int flags = PyCFunction_GET_FLAGS(callable_o); | |
| // METH_CLASS, METH_STATIC and METH_COEXIST do not change the C | |
| // calling convention, and the specializer ignores them. | |
| flags &= ~(METH_CLASS | METH_STATIC | METH_COEXIST); | |
| EXIT_IF(flags != METH_O); | |
| EXIT_IF((PyCFunction_GET_FLAGS(callable_o) & _Py_METH_CALL_FLAGS) != METH_O); |
Author
Comment on lines
+1714
to
+1716
| int flags = PyCFunction_GET_FLAGS(callable_o); | ||
| flags &= ~(METH_CLASS | METH_STATIC | METH_COEXIST); | ||
| if (total_args == 1 && flags == METH_O) { |
Member
There was a problem hiding this comment.
ditto
Suggested change
| int flags = PyCFunction_GET_FLAGS(callable_o); | |
| flags &= ~(METH_CLASS | METH_STATIC | METH_COEXIST); | |
| if (total_args == 1 && flags == METH_O) { | |
| if ((PyCFunction_GET_FLAGS(callable_o) & _Py_METH_CALL_FLAGS) == METH_FASTCALL) { |
cocolato
reviewed
Sep 21, 2026
Comment on lines
+21
to
+24
| try: | ||
| import _testcapi | ||
| except ImportError: | ||
| _testcapi = None |
Member
There was a problem hiding this comment.
Could we move import_helper.import_module("_testcapi") into the six tests that need it, along with their fixture setup? The helper would skip only the current test if the module is unavailable, so we could drop this try/except and the skipIf decorators.
Comment on lines
+40
to
+43
| # Keep these callables in globals so the optimizer can resolve their values. | ||
| # They have METH_CLASS, METH_STATIC, or METH_COEXIST flags. | ||
| if _testcapi is not None: | ||
| METH_CLASS_O = _testcapi.MethClass.meth_o |
Member
There was a problem hiding this comment.
we can define the fixtures in each test and bind them as that function's globals before calling _run_with_optimizer:
testfunc = types.FunctionType(testfunc.__code__, namespace)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157833
Ignore
METH_CLASS,METH_STATICandMETH_COEXISTin the specialized C call guards and corresponding Tier 2 optimizer checks. This prevents calls accepted by the specializer from failing their flag guards on every call.METH_METHODremains checked because it changes the C calling convention.Add Tier 1 and Tier 2 regression tests for all seven affected instructions, regenerate the affected files.
METH_CLASS,METH_STATICorMETH_COEXIST#157833