gh-155266: Fix Argument Clinic for a lone optional group - #155267
Merged
serhiy-storchaka merged 2 commits intoAug 6, 2026
Conversation
If the only parameter of a function was in an optional group, METH_O was generated, which made the argument mandatory and did not pass the flag of the group.
serhiy-storchaka
requested review from
AA-Turner and
erlend-aasland
as code owners
August 6, 2026 07:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option group is now checked before the possibility to use
METH_O.No generated file in the tree is changed, no existing function has such signature.