Accept xz prebuilt archives - #3
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
@native-api Could you take a look when you have a chance? |
native-api
left a comment
There was a problem hiding this comment.
Maybe use bats?
There are only a few tests, but you already have plenty of test framework code.
|
Switched the updater tests to Bats, removed the leftover default and redundant metadata validation, and kept the unsafe-name and missing-artifact checks. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Prerequisite
Description
pythons/update.shto accept.tar.xzprebuilt archives while retaining.tar.gzsupport..tar.xzformat produced bypyenv-binary.Update downloadsfailure in the binary publishing workflow.Tests
.tar.xzindexing and existing.tar.gzcompatibility were checked.git diff --checkpass.Summary by cubic
Drops the
.tar.gz-only filename check inpythons/update.sh, so the updater now accepts.tar.xzprebuilt archives (and any safe archive name from metadata) while retaining.tar.gzsupport, fixing the binary publishing workflow'sUpdate downloadsfailure. Rewrites the updater test in Bats to cover both archive formats, idempotent re-runs, failed runs leaving files unchanged, unsafe-name rejection, and missing-file failures, and documents the Bats test command inREADME.md.Written for commit d74d187. Summary will update on new commits.