Skip to content

fix: Improve group parsing in asound-fix.c and handle errors gracefully - #79

Open
pogof wants to merge 1 commit into
pumpitupdev:masterfrom
pogof:Asound-fix-fix
Open

pogof wants to merge 1 commit into
pumpitupdev:masterfrom
pogof:Asound-fix-fix

Conversation

@pogof

@pogof pogof commented May 31, 2026

Copy link
Copy Markdown
Contributor

This is mainly targeted to get Exceed 1 to work for me as it rejects both dmix and dmix:CARD=PCH,DEV=0. However it also might be part of the issue #78 ? I have no clue, just throwing it on here as draft in case someone else also has issues and wants to test.

Yet to be tested.

EDIT:
Exceed booted with audio when set to patch.sound.device=dmix:CARD=PCH,DEV=0. It did not do that before, it would just crash (same with setting it to just dmix as recommended by the log file).

Since this is also used by MK3 hook, more testing will have to be done with them, otherwise just Exceed is working good.

Edit 2:
Has been tested with all mk3 games and selection of other. Works as intended.

@pogof
pogof marked this pull request as ready for review June 4, 2026 19:06
@voidderef

Copy link
Copy Markdown
Collaborator

I am lacking reasoning as to why this works and what was wrong and not working (correctly) with the old version. Can you elaborate on this a little?

@pogof

pogof commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

From what I understand Exceed 1 is using different audio stuff to literally everything else after it. It was also the only game that would just be mute/didn't boot at all (not 100% sure now) no matter what setting or audio device I tried to use (and I did try basically all 50 or so of them that the log threw at me including the various dmix or virtual devices).

Im not sure if it was throwing some errors at me at the time, I can try to retest, but after bit of prodding it seems like the problem was just how the audio devices were actually parsed (which to be fair is double weird 1) because it seemingly worked for all of the mk3 games 2) the games run on ubuntu 18.04 which is tools target so I would have assumed this would have been caught at some point before?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants