data sync by mohitpubnub · Pull Request #498 · pubnub/javascript

mohitpubnub · 2026-05-22T08:07:36Z

feat(dataSync): Support for dataSync feature.

Added dataSync feature support.

fix(listeners): discard unknown event types

No listener callback will be triggered for event with unknown event types

fix: all events from presence channels will be categorised as presence event

all events from the presence channels will be categorised as presence event

…ases, include PUT type where needed. update body include cases when body present while making http requests.

… definition, updated pubnub-common file to have datasync apis support

coderabbitai · 2026-05-22T08:07:50Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 610da6e3-400c-45fd-b35b-32753824b998

📥 Commits

Reviewing files that changed from the base of the PR and between 7837888 and 9f531f3.

📒 Files selected for processing (1)

.github/workflows/run-tests.yml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

The test workflow now maps three Data Streams secrets to environment variables. It also reports whether DS_SUBSCRIBE_KEY is set before tests run.

Changes

Data Streams workflow configuration

Layer / File(s)	Summary
Configure Data Streams test environment `.github/workflows/run-tests.yml`	The workflow adds subscription, publish, and secret key variables from GitHub secrets. It reports whether `DS_SUBSCRIBE_KEY` is set before tests run.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🟡 Moderate · up to 9f531

The workflow adds Data Streams credentials for testing, but they remain available across the entire job, increasing exposure if a dependency or action is compromised. Narrow secret scope before merging.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title directly identifies the main change: adding data sync support. It is concise and related to the pull request objective.
Description check	✅ Passed	The description explains dataSync support and listener behavior changes. It is related to the changeset and objectives.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch CLEN-3438

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pubnub-ops-terraform · 2026-05-22T08:07:56Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/CODEOWNERS:
- Line 1: The CODEOWNERS entry currently lists "jguz-pubnub" without the
required @ prefix; update the owner token on the same line so it reads
"`@jguz-pubnub`" (i.e., change the token "jguz-pubnub" to "`@jguz-pubnub`") to
ensure GitHub recognizes the user; locate the line containing "*        
`@mohitpubnub` `@parfeon` jguz-pubnub" and add the missing @ before jguz-pubnub.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f3bb076d-503f-4e28-b5b9-465bfb055e22

📥 Commits

Reviewing files that changed from the base of the PR and between 0ad7d97 and e82c07a.

⛔ Files ignored due to path filters (64)

dist/web/pubnub.js is excluded by !**/dist/**, !dist/** and included by none
dist/web/pubnub.min.js is excluded by !**/dist/**, !**/*.min.js, !dist/** and included by none
dist/web/pubnub.worker.js is excluded by !**/dist/**, !dist/** and included by none
dist/web/pubnub.worker.min.js is excluded by !**/dist/**, !**/*.min.js, !dist/** and included by none
lib/core/components/request.js is excluded by !lib/** and included by none
lib/core/constants/operations.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/entity/create.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/entity/get-all.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/entity/get.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/entity/patch.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/entity/remove.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/entity/update.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/relationship/create.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/relationship/get-all.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/relationship/get.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/relationship/patch.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/relationship/remove.js is excluded by !lib/** and included by none
lib/core/endpoints/data_sync/relationship/update.js is excluded by !lib/** and included by none
lib/core/pubnub-common.js is excluded by !lib/** and included by none
lib/core/pubnub-data-sync.js is excluded by !lib/** and included by none
lib/core/types/api/data-sync.js is excluded by !lib/** and included by none
lib/core/types/transport-request.js is excluded by !lib/** and included by none
lib/errors/pubnub-api-error.js is excluded by !lib/** and included by none
lib/transport/middleware.js is excluded by !lib/** and included by none
lib/types/index.d.ts is excluded by !lib/** and included by none
package-lock.json is excluded by !**/package-lock.json, !package-lock.json and included by none
src/core/components/request.ts is excluded by none and included by none
src/core/constants/operations.ts is excluded by none and included by none
src/core/endpoints/data_sync/channel/create.ts is excluded by none and included by none
src/core/endpoints/data_sync/channel/get-all.ts is excluded by none and included by none
src/core/endpoints/data_sync/channel/get.ts is excluded by none and included by none
src/core/endpoints/data_sync/channel/patch.ts is excluded by none and included by none
src/core/endpoints/data_sync/channel/remove.ts is excluded by none and included by none
src/core/endpoints/data_sync/channel/update.ts is excluded by none and included by none
src/core/endpoints/data_sync/entity/create.ts is excluded by none and included by none
src/core/endpoints/data_sync/entity/get-all.ts is excluded by none and included by none
src/core/endpoints/data_sync/entity/get.ts is excluded by none and included by none
src/core/endpoints/data_sync/entity/patch.ts is excluded by none and included by none
src/core/endpoints/data_sync/entity/remove.ts is excluded by none and included by none
src/core/endpoints/data_sync/entity/update.ts is excluded by none and included by none
src/core/endpoints/data_sync/membership/create.ts is excluded by none and included by none
src/core/endpoints/data_sync/membership/get-all.ts is excluded by none and included by none
src/core/endpoints/data_sync/membership/get.ts is excluded by none and included by none
src/core/endpoints/data_sync/membership/patch.ts is excluded by none and included by none
src/core/endpoints/data_sync/membership/remove.ts is excluded by none and included by none
src/core/endpoints/data_sync/membership/update.ts is excluded by none and included by none
src/core/endpoints/data_sync/relationship/create.ts is excluded by none and included by none
src/core/endpoints/data_sync/relationship/get-all.ts is excluded by none and included by none
src/core/endpoints/data_sync/relationship/get.ts is excluded by none and included by none
src/core/endpoints/data_sync/relationship/patch.ts is excluded by none and included by none
src/core/endpoints/data_sync/relationship/remove.ts is excluded by none and included by none
src/core/endpoints/data_sync/relationship/update.ts is excluded by none and included by none
src/core/endpoints/data_sync/user/create.ts is excluded by none and included by none
src/core/endpoints/data_sync/user/get-all.ts is excluded by none and included by none
src/core/endpoints/data_sync/user/get.ts is excluded by none and included by none
src/core/endpoints/data_sync/user/patch.ts is excluded by none and included by none
src/core/endpoints/data_sync/user/remove.ts is excluded by none and included by none
src/core/endpoints/data_sync/user/update.ts is excluded by none and included by none
src/core/pubnub-common.ts is excluded by none and included by none
src/core/pubnub-data-sync.ts is excluded by none and included by none
src/core/types/api/data-sync.ts is excluded by none and included by none
src/core/types/transport-request.ts is excluded by none and included by none
src/errors/pubnub-api-error.ts is excluded by none and included by none
src/transport/middleware.ts is excluded by none and included by none

📒 Files selected for processing (1)

.github/CODEOWNERS

…put accepted

…y not typinf domain keywords during parameter property inputs, update method name conventions to align with existing methods. update parse token to parse dataSync related permissions and projection definitions details. added more patch operation variants which are supported.

…nfiguration update for dataSync tests

… fixes existing tests which were affected by nock setup.

parfeon

LGTM!

parfeon

LGTM!

…pertaion events

parfeon

LGTM!

mohitpubnub · 2026-09-08T16:35:22Z

@pubnub-release-bot release as v13.0.0

pubnub-release-bot · 2026-09-08T16:51:44Z

🚀 Release successfully completed 🚀

Mohit Tejani added 9 commits May 22, 2026 13:27

pre-requisites for data_sync: handle error array during exceptional c…

0c83fb4

…ases, include PUT type where needed. update body include cases when body present while making http requests.

data-sync: channel endpoint apis

5502af9

data-sync:user endpoint apis

ea6da83

data-sync:membership endpoint apis

f128cbc

data-sync: entity endpoint apis

fbe3e3c

data-sync: entity-relationship endpoint apis

8734092

data-sync: apis domain object export, added operation constants, type…

1843165

… definition, updated pubnub-common file to have datasync apis support

updated dist/lib and codeowner files.

7a5a27f

fix lint

e82c07a

coderabbitai Bot reviewed May 22, 2026

View reviewed changes

Comment thread .github/CODEOWNERS Outdated

mohitpubnub and others added 6 commits May 22, 2026 13:40

Fix CODEOWNERS syntax for jguz-pubnub

f57123e

dataSync relationship api for getAll should have class and version in…

3876080

…put accepted

sync package.json with latest

adbfa29

fix type definition for getAllRelationships

fd1b9e4

Merge branch 'master' into CLEN-3438

66391b4

Merge branch 'master' into CLEN-3438

97152c2

mohitpubnub marked this pull request as ready for review June 25, 2026 08:33

mohitpubnub requested review from jguz-pubnub and parfeon as code owners June 25, 2026 08:33

Mohit Tejani and others added 9 commits July 10, 2026 14:57

datasync event handling, grantToken update for datasync permissions

4be5002

remove idempotencyKey from datasync apis

25eb24d

Merge branch 'master' into CLEN-3438

f51c1dc

lint fixes

6d2d137

Merge branch 'master' into CLEN-3438

2d6a210

handling user/channel/membership events in subscription

c5be680

lib files

8d7f54f

dist/lib updates

7fa7586

mohitpubnub added 7 commits September 7, 2026 21:06

.pubnub.yml updates for dataSync

5fdd27d

update configuration as custom origin not needed for dataSync tests

c801cc8

test(fix) for membership error assertion, test fix for projection, co…

7837888

…nfiguration update for dataSync tests

test environment variable configuration update

e17c7b5

test config, dataSync environment configuration

9f531f3

reverted run-tests workflow changes, added tests for dataSync events,…

b04a75e

… fixes existing tests which were affected by nock setup.

dist/lib updates

5b07221

mohitpubnub requested a review from parfeon September 7, 2026 18:49

parfeon approved these changes Sep 8, 2026

View reviewed changes

mohitpubnub added 2 commits September 8, 2026 12:06

dataSync parameter naming sync for get*s operation

bb98219

dist/lib updates

03239d2

mohitpubnub requested a review from parfeon September 8, 2026 06:40

mohitpubnub added status: done This issue is considered resolved. javascript labels Sep 8, 2026

parfeon approved these changes Sep 8, 2026

View reviewed changes

mohitpubnub added 2 commits September 8, 2026 21:08

update dataSync event type parsing for user, channel and membership o…

8997be8

…pertaion events

dist/lib updates

fb8ffcf

mohitpubnub requested a review from parfeon September 8, 2026 16:07

mohitpubnub added 2 commits September 8, 2026 21:57

dataSync eventType redundant definition cleanup

d386315

dist/lib updates

ffbcc81

parfeon approved these changes Sep 8, 2026

View reviewed changes

mohitpubnub and others added 2 commits September 8, 2026 22:07

package-lock file

6573b67

PubNub SDK v13.0.0 release.

6fd7e43

pubnub-release-bot requested review from kazydek and techwritermat as code owners September 8, 2026 16:40

mohitpubnub merged commit 10f84a2 into master Sep 8, 2026
10 checks passed

mohitpubnub deleted the CLEN-3438 branch September 8, 2026 16:46

mohitpubnub mentioned this pull request Sep 8, 2026

subscribe listenr callback update to handle unknown event types #508

Closed

Navigation Menu

Uh oh!

data sync - #498

data sync#498
mohitpubnub merged 62 commits into
masterfrom
CLEN-3438

mohitpubnub commented May 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 22, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

Uh oh!

pubnub-ops-terraform commented May 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

parfeon left a comment

Uh oh!

parfeon left a comment

Uh oh!

parfeon left a comment

Uh oh!

mohitpubnub commented Sep 8, 2026

Uh oh!

Uh oh!

pubnub-release-bot commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mohitpubnub commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

pubnub-ops-terraform commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

parfeon left a comment

Choose a reason for hiding this comment

Uh oh!

parfeon left a comment

Choose a reason for hiding this comment

Uh oh!

parfeon left a comment

Choose a reason for hiding this comment

Uh oh!

mohitpubnub commented Sep 8, 2026

Uh oh!

Uh oh!

pubnub-release-bot commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mohitpubnub commented May 22, 2026 •

edited

Loading

coderabbitai Bot commented May 22, 2026 •

edited

Loading

pubnub-ops-terraform commented May 22, 2026 •

edited

Loading