ok another stupid review, still fixing issues - #1044
Merged
kevinaboos merged 2 commits intoAug 29, 2026
Conversation
* the "invite was already accepted elsewhere" branch returned without setting `is_loaded`, which is exactly the condition the `Event::Signal` handler re-enters on, so it re-emitted `InviteAccepted` on every single signal * `start_search()` takes key focus before the pane's first draw, when its area is still empty, so `hide()`'s area check never gave the focus back. Track the area we actually focused instead.
kevinaboos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_loaded, so it kept re-emitted theInviteAcceptedaction on every signal