Misc fixes related to a review of recent changes - #1041
Merged
Conversation
* logout didn't re-broadcast prefs, so the read receipt atomic kept the old account's value * `reconnect_timeline_endpoints` didn't re-issue room subscriptions after a rebuild * the 3 `TimelineUpdate` sends that `unwrap()` now log on a dropped receiver * re-subscribing to pinned events orphaned the old task * `start_timer` was a throttle, not the debounce it documents (also fixes fling receipts) * `add_displayed_joined_room` appended instead of using `all_known_rooms_order` * a room profile lookup that found no member sat at `Requested` forever * the AUR approval baseline only snapshotted `PKGBUILD`
`add_displayed_joined_room` gets its insert index from `all_known_rooms_order`, which is only the real order while `sort_fn` is `None`. append instead, so wiring up sorting later doesn't silently misplace rooms.
the room-specific lookup path is hard to hit by hand, so cover the terminal state logic directly instead.
`show_timeline()` kicks off `SyncRoomMemberList` and then immediately reads the local member cache, so it only gets whatever lazy loading had delivered so far. `RoomMembersSynced` was a no-op, so the mention popup was stuck with that partial list for the life of the room view.
`AddJoinedSpace` for a space we already had logged a BUG and left `displayed_spaces` alone, so a re-add with a changed name never entered or left the bar. it's an upsert, not a bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reconnect_timeline_endpoints()didn't properly re-setup room subscriptions after a timeline got recreated.add_displayed_joined_roomjust blindly appended the room instead of using the proper ordering (not really a problem since we don't actually use the sort fn, but still, we might one day)