refactor(database/prometheus): Encode missing tags as empty labels - #916
Merged
Conversation
Use an empty label value when a configured tag is absent from PowerReport metadata instead of assigning the synthetic "unknown" value. This aligns missing tags with Prometheus semantics and avoids conflating absent metadata with a legitimate "unknown" tag value.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #916 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 86 86
Lines 3167 3167
=======================================
Hits 2542 2542
Misses 625 625
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an empty label value when a configured tag is absent from PowerReport metadata instead of assigning the synthetic "unknown" value.
This aligns missing tags with Prometheus semantics and avoids conflating absent metadata with a legitimate "unknown" tag value.