Skip to content

Eliminate the pre-push hook test race #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morgaesis merged 1 commit into from
Aug 27, 2026
Merged

Eliminate the pre-push hook test race #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/hook.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,11 @@ mod tests {
fake_bin.display(),
std::env::var("PATH").unwrap_or_default()
);
let mut child = Command::new(hook)
// Executable permissions are asserted separately. Invoking the script
// through its interpreter avoids a transient ETXTBSY race on filesystems
// that delay releasing a newly written script for direct execution.
let mut child = Command::new("sh")
.arg(hook)
.args(["origin", &remote.to_string_lossy()])
.current_dir(repo)
.env("PATH", path)
Expand Down Expand Up @@ -217,6 +221,7 @@ mod tests {
install(dir.path(), false).unwrap();
let hook = dir.path().join(".git/hooks/pre-push");
let script = std::fs::read_to_string(&hook).unwrap();
assert!(script.starts_with("#!/bin/sh\n"));
assert!(script.contains("while read -r local_ref local_oid"));
assert!(script.contains("git diff --find-renames \"$remote_oid\" \"$local_oid\""));
assert!(script.contains("postil review --bounded --diff-file \"$tmp\""));
Expand Down Expand Up @@ -280,7 +285,7 @@ mod tests {
}

#[test]
fn executable_hook_reviews_exact_refs_and_skips_non_branches() {
fn installed_hook_reviews_exact_refs_and_skips_non_branches() {
let dir = tempfile::tempdir().unwrap();
let repo = dir.path().join("repo");
let remote = dir.path().join("remote.git");
Expand Down