Report 22003 for out-of-range integer conversions instead of silently wrapping (#207) - #210
Merged
Merged
Conversation
…#207) SQLGetData/SQLBindCol of an integer value that does not fit the requested C type stored the low bits and returned SQL_SUCCESS -- e.g. 9223372036854775807::bigint read as SQL_C_SLONG gave -1, 70000::int4 as SQL_C_SSHORT gave 4464. pg_atoi/pg_atol parse into a wide integer and the narrowing assignment silently truncates; nothing range-checked the value. ODBC specifies SQL_ERROR with SQLSTATE 22003 (numeric value out of range). Add int_value_out_of_range() and range-check the parsed value against the target C type's limits in the SQL_C_[S|U]TINYINT / [S|U]SHORT / [S|U]LONG / [S|U]BIGINT branches of copy_and_convert_field(); on overflow leave the buffer untouched and return the new COPY_RESULT_OVERFLOW, mapped to STMT_VALUE_OUT_OF_RANGE (22003) in the SQLGetData and SQLFetch/SQLBindCol paths. Also correct the STMT_VALUE_OUT_OF_RANGE ODBC3 SQLSTATE, which was HY019 rather than 22003 (the code had no other users). Values that fit are unchanged; SQL_C_SBIGINT and SQL_C_NUMERIC were already correct. New int-overflow-test covers the issue's cases; result-conversions expected output updated where it previously captured the wrapped values.
davecramer
added a commit
that referenced
this pull request
Sep 8, 2026
…eview) On the SQL_ERROR path for a numeric-out-of-range conversion the data buffer is left untouched; skip writing the length/indicator too, for symmetry. Within spec either way (buffer/indicator undefined after SQL_ERROR), per review feedback on #210.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #207.
Problem
SQLGetData/SQLBindColof an integer that does not fit the requested C type returnedSQL_SUCCESSwith the wrapped low bits, no diagnostic:9223372036854775807::bigintasSQL_C_SLONG->-1, asSQL_C_SSHORT->-14294967297::bigintasSQL_C_SLONG->170000::int4asSQL_C_SSHORT->4464ODBC specifies
SQL_ERRORwith SQLSTATE22003(numeric value out of range).copy_and_convert_field()parsed withpg_atoi/pg_atolinto a wide integer and the narrowing assignment truncated; nothing range-checked.Fix
int_value_out_of_range()(parse once into 64-bit, flagERANGEor out-of-[min,max]).SQL_C_[S|U]TINYINT/[S|U]SHORT/[S|U]LONG/[S|U]BIGINTbranches; on overflow leave the buffer untouched and return a newCOPY_RESULT_OVERFLOW, mapped toSTMT_VALUE_OUT_OF_RANGE(22003) in both theSQLGetData(results.c) andSQLFetch/SQLBindCol(statement.c) paths.STMT_VALUE_OUT_OF_RANGEODBC3 SQLSTATE, which wasHY019instead of22003(no other code used it).Values that fit are unchanged;
SQL_C_SBIGINTandSQL_C_NUMERICwere already correct.Verification (PostgreSQL 18)
Issue repro now returns
22003for the four out-of-range reads and the exact values for the in-range ones.New
int-overflow-testcovers these cases.result-conversionsexpected output updated where it previously captured the wrapped values (all changes are out-of-range narrowings now reporting 22003);numeric,getresultunchanged.