Skip to content

Update StringHelper to avoid converting int's encoding to utf8 - #222

Closed
REJack wants to merge 1 commit into
planetteamspeak:devfrom
REJack:avoid-convert-ints-enconding-to-utf8
Closed

REJack wants to merge 1 commit into
planetteamspeak:devfrom
REJack:avoid-convert-ints-enconding-to-utf8

Conversation

@REJack

@REJack REJack commented Jun 20, 2024

Copy link
Copy Markdown

Hi together,

I recently hit an problem with the latest version (1.3.0) & with dev branch.
If I select an server by id and the serverId is 11+ it results in an convert error,

After some research I found out that using mb_convert_encoding on 11-19 result in some weird characters like ㄱ as 11 or ㄹ as 19 🤣

I assume that will fix #212.

@maxbrokman

Copy link
Copy Markdown

Also have encountered the same problem, especially with server group IDs getting converted into Japanese Kanji. We have a fork that implements the same fix and works. It might also be worth skipping the StringHelper entirely when the value is an integer or a Node->getId() as well?

@Sebbo94BY

Copy link
Copy Markdown
Collaborator

The commit 3f9778d fixed this issue more properly, thus I'll close this PR.

@Sebbo94BY Sebbo94BY closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants