You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @Alex-nz, sorry for the wait! Busy time + vacation time...
The plugin changes are good! I would have an additional suggestion: to check if the submission's context ID is the same as the current context -- currently the submission ID is taken directly from the query string in wosRLHandler.php in getTemplate() and getReviewerList(), e.g. something like:
$context = $request->getContext();
$submission = !empty($params['submissionId']) ? Repo::submission()->get((int) $params['submissionId']) : null;
if (!$submission || (int) $submission->getData('contextId') !== (int) $context->getId()) {
return error element for template or JSONMessage
}
Let me know if you would like to change this too first.
Thanks!
Hi @bozana , thanks for the review and my turn to apologize for the delayed response.
We have some other improvements in mind for the plugin, so we can implement your suggestion at the same time as these updates. Can we please add this version as is. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the most recent version of the plugin to the gallery. This version fixes issues with plugin availability for certain user roles.