Skip to content

Renaming the “Selection of Review Interests” plugin to “Predefined Review Interests” - #501

Merged
bozana merged 2 commits into
pkp:mainfrom
lepidus:predefinedReviewingInterestsRenaming
Aug 11, 2026
Merged

Renaming the “Selection of Review Interests” plugin to “Predefined Review Interests”#501
bozana merged 2 commits into
pkp:mainfrom
lepidus:predefinedReviewingInterestsRenaming

Conversation

@YvesLepidus

Copy link
Copy Markdown

In addition to the renaming, the releases also include bug fixes and documentation improvements.

@bozana
bozana merged commit 7008293 into pkp:main Aug 11, 2026
1 check passed
@bozana

bozana commented Aug 11, 2026

Copy link
Copy Markdown

Hi @YvesLepidus, sorry for the wait -- very busy time!
Everything looks good. I would have a few suggestions for a future releases:

v2.0.x / v3.0.x (HookCallbacks.php):

  1. filterReviewersByInterest() reads interestOption from the raw request on every User::Collector hook call, without checking that this is actually the reviewer-selection query. Could be worth guarding it with if (!$collector->includeReviewerData) return false; — the property is set by core for this case, so maybe to scope the filter to the reviewer panel only, instead of any user listing that happens to have ?interestOption= in the URL.
  2. addInterestFilterParam() doesn't validate interestOption against the journal's configured option list before use (the v1.0.x branch does this). Maybe a good defense-in-depth and matches your own v1.0.x pattern.

v3.0.x (getInterestsPatchInlineMarkup()): the plugin's own JS/CSS files are now file_get_contents()'d and concatenated raw into <script>/<style> tags, which drops browser caching of these assets for no functional gain since they're static.

v1.0.x (getReviewerInterestFilterComponentScriptTag()): builds a <script src="..."> tag from getBaseUrl() without htmlspecialchars(), inconsistent with the escaping used a few lines away in getInterestsAssetsMarkup(). Low risk under normal server config, but worth aligning/fixing.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants