Enable Renovate lockFileMaintenance to remediate transitive CVEs - #301
Merged
Conversation
The repo has 51 open Dependabot alerts, all transitive (lockfile-only). Renovate's vulnerabilityAlerts only opens PRs for deps it manages, i.e. entries in package.json - dashboard #68 lists 15 detected npm deps, none of which are the vulnerable ones. The transitiveRemediation option that used to cover this was removed from Renovate. lockFileMaintenance is the supported mechanism: it deletes yarn.lock and regenerates it, so transitive deps float up to the newest version their parents' ranges already allow. Verified locally that this clears 42 of the 51 alerts, including CVE-2026-54466 (websocket-driver, critical); yarn build passes on the result. Also unsets prHourlyLimit for vulnerabilityAlerts - security PRs are exempt from schedule and prConcurrentLimit by default, but not from the hourly limit, so the repo-level cap of 2 was throttling them. schedule is temporarily "at any time" to force an initial catch-up run; a follow-up will restore it to "before 8am on monday". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dunningdan
enabled auto-merge
September 4, 2026 20:46
drdavella
approved these changes
Sep 4, 2026
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
51 open Dependabot alerts on this repo, all transitive (present only in
yarn.lock, nothing inpackage.json). Renovate has never touched them, and wasn't going to.Renovate's
vulnerabilityAlertsonly opens PRs for dependencies it manages — direct deps. Dependency Dashboard #68 confirms this: under "Detected Dependencies → npm → package.json" it lists 15 packages, and not one of the 51 vulnerable ones is among them. ThetransitiveRemediationoption that used to cover this case has been removed from Renovate (discussion); maintainers point tolockFileMaintenanceinstead.Change
Enables
lockFileMaintenance, which deletes the lock file and regenerates it, letting transitive deps float up to the newest version their parents' ranges already permit. It is schedule-driven, not triggered by new releases — so it will pick up the existing 7-week backlog on its first run.Also unsets
prHourlyLimitinsidevulnerabilityAlerts. Security PRs are exempt fromscheduleandprConcurrentLimitby default, but not from the hourly limit, so the repo-level cap of 2 was silently throttling them.Verification
Simulated locally exactly as Renovate does it (
rm yarn.lock && yarn install, Node 24.20.0):package.jsonunchanged ✅websocket-driver— CVE-2026-54466, critical (CVSS 9.2) → 0.7.5yarn buildpasses, 59 documents processed ✅What this does not fix
9 alerts survive, because re-resolution provably cannot reach them:
minimatch,yaml9.0.3,2.8.1)serialize-javascript,uuidimage-sizeThe first two rows need
resolutionsoverrides inpackage.json— a follow-up PR.image-sizeneeds a documented risk acceptance (build-time only, reached via@docusaurus/mdx-loader, DoS on malformed.icns, no untrusted image input path).Follow-ups
lockFileMaintenance.scheduletobefore 8am on monday(temporarilyat any timehere to force the catch-up run)resolutionsforminimatch/yaml/serialize-javascript/uuid(verified locally: clears 7 more, build + dev server both green)image-sizeISS-924 Add Dependency FAQ #186/Docs refactor and updates #187🤖 Generated with Claude Code