Skip to content

feat: Add Toggle Terminal to View Menu - #6070

Open
mohamedmastouri-hue wants to merge 1 commit into
pingdotgg:mainfrom
mohamedmastouri-hue:feature-open-terminal
Open

feat: Add Toggle Terminal to View Menu#6070
mohamedmastouri-hue wants to merge 1 commit into
pingdotgg:mainfrom
mohamedmastouri-hue:feature-open-terminal

Conversation

@mohamedmastouri-hue

@mohamedmastouri-hue mohamedmastouri-hue commented Aug 10, 2026

Copy link
Copy Markdown

Adds a menu item to explicitly toggle the terminal drawer from the desktop View menu.


Note

Low Risk
Small UI/menu bridge that reuses existing terminal toggle logic with no auth, data, or security changes.

Overview
Adds Toggle Terminal to the desktop View menu (accelerator Cmd/Ctrl+J), dispatching a toggle-terminal menu action into the renderer.

AppSidebarLayout handles that action by emitting a window t3-action:toggle-terminal custom event; ChatView listens and calls the existing toggleTerminalVisibility path (same behavior as the configured terminal.toggle shortcut). The global keydown listener in ChatView is only renamed for clarity.

Reviewed by Cursor Bugbot for commit 945629e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Toggle Terminal to the desktop View menu with CmdOrCtrl+J

  • Adds a 'Toggle Terminal' item to the desktop View menu in DesktopApplicationMenu.ts, dispatching a toggle-terminal menu action via the desktop bridge.
  • AppSidebarLayout.tsx listens for the toggle-terminal menu action and emits a t3-action:toggle-terminal DOM event on window.
  • ChatView.tsx registers a listener for t3-action:toggle-terminal and calls toggleTerminalVisibility in response.

Macroscope summarized 945629e.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b77698a-8c01-415b-b0c9-ffef5334b525

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 10, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 945629e. Configure here.

label: "Toggle Terminal",
accelerator: "CmdOrCtrl+J",
click: () => runMenuEffect("toggle-terminal", dispatchMenuAction("toggle-terminal")),
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortcut double-toggles terminal

High Severity

The new View menu item registers a native CmdOrCtrl+J accelerator while terminal.toggle already handles mod+j in ChatView. On desktop, one keypress can run both the menu IPC path (t3-action:toggle-terminal) and the existing keydown handler, so toggleTerminalVisibility runs twice and the drawer ends up unchanged. This also hard-binds J regardless of user keybinding remaps.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 945629e. Configure here.

@macroscopeapp

macroscopeapp Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

An unresolved HIGH severity bug finding identifies that the new CmdOrCtrl+J menu accelerator conflicts with the existing keydown handler, causing the terminal to toggle twice (net no change). This logic issue should be addressed before merging.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant