feat: Add Toggle Terminal to View Menu - #6070
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 945629e. Configure here.
| label: "Toggle Terminal", | ||
| accelerator: "CmdOrCtrl+J", | ||
| click: () => runMenuEffect("toggle-terminal", dispatchMenuAction("toggle-terminal")), | ||
| }, |
There was a problem hiding this comment.
Shortcut double-toggles terminal
High Severity
The new View menu item registers a native CmdOrCtrl+J accelerator while terminal.toggle already handles mod+j in ChatView. On desktop, one keypress can run both the menu IPC path (t3-action:toggle-terminal) and the existing keydown handler, so toggleTerminalVisibility runs twice and the drawer ends up unchanged. This also hard-binds J regardless of user keybinding remaps.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 945629e. Configure here.
ApprovabilityVerdict: Needs human review An unresolved HIGH severity bug finding identifies that the new CmdOrCtrl+J menu accelerator conflicts with the existing keydown handler, causing the terminal to toggle twice (net no change). This logic issue should be addressed before merging. You can customize Macroscope's approvability policy. Learn more. |


Adds a menu item to explicitly toggle the terminal drawer from the desktop View menu.
Note
Low Risk
Small UI/menu bridge that reuses existing terminal toggle logic with no auth, data, or security changes.
Overview
Adds Toggle Terminal to the desktop View menu (accelerator Cmd/Ctrl+J), dispatching a
toggle-terminalmenu action into the renderer.AppSidebarLayouthandles that action by emitting a windowt3-action:toggle-terminalcustom event;ChatViewlistens and calls the existingtoggleTerminalVisibilitypath (same behavior as the configuredterminal.toggleshortcut). The global keydown listener inChatViewis only renamed for clarity.Reviewed by Cursor Bugbot for commit 945629e. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add Toggle Terminal to the desktop View menu with
CmdOrCtrl+Jtoggle-terminalmenu action via the desktop bridge.toggle-terminalmenu action and emits at3-action:toggle-terminalDOM event onwindow.t3-action:toggle-terminaland callstoggleTerminalVisibilityin response.Macroscope summarized 945629e.