Skip to content

Fix for issue 123 - #6066

Open
mohamedmastouri-hue wants to merge 1 commit into
pingdotgg:mainfrom
mohamedmastouri-hue:fix-issue-123
Open

Fix for issue 123#6066
mohamedmastouri-hue wants to merge 1 commit into
pingdotgg:mainfrom
mohamedmastouri-hue:fix-issue-123

Conversation

@mohamedmastouri-hue

@mohamedmastouri-hue mohamedmastouri-hue commented Aug 10, 2026

Copy link
Copy Markdown

Fixes issue #123


Note

Low Risk
UI-only visibility toggle reusing existing setTerminalOpen state; no changes to terminal lifecycle or server behavior beyond hiding the drawer.

Overview
Adds a Hide Terminal control to the thread terminal UI so users can collapse the drawer without closing terminal sessions.

ChatView wires a new onHideDrawer handler that sets terminalOpen to false via the terminal UI store for the current thread. ThreadTerminalDrawer accepts optional onHideDrawer and renders a chevron-down action in both the panel and compact toolbars (next to new/split/close), only when that callback is provided.

Reviewed by Cursor Bugbot for commit 4d7886f. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add 'Hide Terminal' button to ThreadTerminalDrawer

Adds an optional onHideDrawer prop to ThreadTerminalDrawer. When provided, a 'Hide Terminal' button (ChevronDown icon) appears in both drawer and panel action bars. PersistentThreadTerminalDrawer supplies the handler, which sets terminalOpen=false for the thread via the terminal UI state store.

Macroscope summarized 4d7886f.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 23e14056-d684-465d-84f6-a19ab18305ff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 10, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 4d7886f

Straightforward UI enhancement adding a 'Hide Terminal' button using existing state management. The change is purely additive with an optional prop, backwards-compatible, and doesn't alter existing behavior.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant