Name the node types the arithmetic operand rules want - #337
Merged
Merged
Conversation
Each of them handles one operator in its binary and its compound-assign form, and registered for Expr to get both - so it was called for every expression in the analysed code just to reject it. PHPStan 2.3.0's MultipleNodeTypesRule lets them name the two classes instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QL6WG3TUaXc6ggSoDLdorG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to phpstan/phpstan-src#6540, which added
MultipleNodeTypesRule.The six
OperandsInArithmetic*Ruleeach handle one operator in its binary form (BinaryOp\Plus) and its compound-assign form (AssignOp\Plus). Since those two share no ancestor of their own, the rules registered forExprand rejected everything else inprocessNode()— which meant being called for every expression in the analysed code to do so. On phpstan-src's own analysis that was 258K calls each, 1.5M in total, essentially all of them returning nothing.getNodeTypes()now names the two classes.getNodeType()staysExpr, soprocessNode()'s parameter type is unchanged, and theinstanceofchecks stay where they are — they still pick the operands apart, they are just no longer the filter.Measured on phpstan-src's own analysis: these six rules plus
DataProviderDataRule(phpstan/phpstan-phpunit#…) take the −2.80% of #6540 to −3.65%.make checkpasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01QL6WG3TUaXc6ggSoDLdorG